[csv-] use newline='' for opening files #2374
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The csv library documentation says "If newline='' is not specified, newlines embedded inside quoted fields will not be interpreted correctly [...] . It should always be safe to specify newline='', since the csv module does its own (universal) newline handling." https://docs.python.org/3/library/csv.html#id4
saulpw
added a commit
that referenced
this pull request
May 17, 2024
|
Okay, so I made a small change to We have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The csv loader should use
newline=''. According to the csv library documentation:newline=''is already used for saving CSV files (#1362), added by 7a5e834.An example file that demonstrates the difference:
newlines.csv
In
vd newlines.csv, the third row, second column, loads as"\n"(on my Ubuntu system where newline is"\n". On Windows it would load as"\r\n", I think.). After the patch it loads as"\r\n".I'm making this PR a draft, pending others' input, since I'm not well-versed in parsing CSV files.
Is there a canonical test suite of CSV files for parsing? I'd prefer to test this change before it's deployed.