[color-] make status colors more readable #2373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
develop
, but not in v3.0.2, the display of the last command is hard to read. It's cyan on light blue:That's because
color_longname
is currently6
, which is cyan. It's hard to pick a text color that is readable against the light blue status bar and also readable against the green guide, so this PR splitscolor_longname
into two settings,color_longname_guide
andcolor_longname_status
.A couple of other color changes:
For the
ascii8
theme: the progress indicator (loading...
) is hard to read, ascolor_working
is currentlygreen
, on a cyan background. So I've changed it tobold white
. Of the 8 foreground color choices, magenta and yellow were a bit too faint, red looked like an error, and the rest were too hard to read.Also for
ascii8
, longname is currently invisible, cyan on cyan. The new default color forcolor_longname_status
fixes this too.And the lower right corner of the guide box has a stray bracket character. It currently reads:
toggle sidebar |[┘
, which this PR changes totoggle sidebar |─┘
.The reason for choosing
white
forcolor_longname_status
, is that it's readable against the light blue status bar for the default theme, as well as against cyan for theascii8
theme. If there are better colors, please feel free to go with those.