[save-] before saving, load unloaded sheets #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we fail outright, or call |
|
Good point, loading is definitely better. I've changed it to call |
midichef
changed the title
saulpw
reviewed
Mar 13, 2024
| @@ -109,6 +109,8 @@ def saveSheets(vd, givenpath, *vsheets, confirm_overwrite=True): | |||
| if not vsheets: # blank tuple | |||
| vd.warning('no sheets to save') | |||
| return | |||
| unloaded = [ vs for vs in vsheets if vs.rows is UNLOADED ] | |||
| vd.sync(*vd.ensureLoaded(unloaded)) | |||
There was a problem hiding this comment.
Closer! But ensureLoaded is on BaseSheet, not the vd object. And it also checks for UNLOADED itself. So maybe we should make vd.sync ignore None values, and just call vd.sync(*[vs.ensureLoaded() for vs in vsheets]).
saulpw
approved these changes
Mar 17, 2024
|
This is so cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repro:
then
vd unloaded.vdswill show that two of the sheets have no rows.Also, saving a sheet with 0 rows results in a .vds file that's not readable. I'll file that as a separate issue.