[memory] shorten cells too wide to fit in prompt

visidata/_input.py

@@ -404,8 +404,12 @@ def inputsingle(vd, prompt, record=True):
  return v
 
 @VisiData.api
-def inputMultiple(vd, updater=lambda val: None, record=True, **kwargs):
- 'A simple form, where each input is an entry in `kwargs`, with the key being the key in the returned dict, and the value being a dictionary of kwargs to the singular input().'
+def inputMultiple(vd, updater=lambda val: None, record=True, readonly_keys = (), **kwargs):
+ '''A simple form, where each input is an entry in `kwargs`, with
+ the key being the key in the returned dict, and the value being a
+ dictionary of kwargs to the singular input(). *readonly_keys* is
+ a tuple of keys in `kwargs`; for each key, its corresponding value
+ will be displayed as a field that cannot be tabbed into or edited.'''
  sheet = vd.activeSheet
  scr = sheet._scr
 
@@ -429,8 +433,8 @@ def inputMultiple(vd, updater=lambda val: None, record=True, **kwargs):
  maxw = sheet.windowWidth//2
  attr = colors.color_edit_unfocused
 
- keys = list(kwargs.keys())
- cur_input_key = keys[0]
+ editable_keys = [k for k in kwargs.keys() if k not in readonly_keys]
+ cur_input_key = editable_keys[0]
 
  if scr:
  scr.erase()
@@ -477,8 +481,8 @@ def _drawPrompt(val):
  except ChangeInput as e:
  input_kwargs['value'] = e.args[0]
  offset = e.args[1]
- i = keys.index(cur_input_key)
- cur_input_key = keys[(i+offset)%len(keys)]
+ i = editable_keys.index(cur_input_key)
+ cur_input_key = editable_keys[(i+offset)%len(editable_keys)]
 
  retargs = {}
  lastargs = {}

visidata/memory.py

@@ -9,6 +9,19 @@ def memo(vd, name, col, row):
  vd.memory[name] = col.getTypedValue(row)
  vd.status('memo %s=%s' % (name, col.getDisplayValue(row)))
 
+@Sheet.api
+def memo_cell(sheet):
+ if not sheet.cursorCol or not sheet.cursorRow: return
+ value_params = dict(prompt='assign value: ', value=sheet.cursorDisplay)
+ name_params = dict(prompt='to memo name: ')
+ # edits to memo_value are blocked, to preserve its type #2287
+ inputs = vd.inputMultiple(memo_name=name_params,
+ memo_value=value_params,
+ readonly_keys=('memo_value',))
+ if not inputs['memo_name']:
+ vd.fail('memo name cannot be blank')
+ vd.memory[inputs['memo_name']] = sheet.cursorTypedValue
+ vd.status(f'memo {inputs["memo_name"]}={sheet.cursorDisplay}')
 
 class MemorySheet(Sheet):
  rowtype = 'memos' # rowdef: keys into vd.memory
@@ -32,4 +45,4 @@ def memosSheet(vd):
 
 
 Sheet.addCommand('Alt+Shift+M', 'open-memos', 'vd.push(vd.memosSheet)', 'open the Memory Sheet')
-Sheet.addCommand('Alt+m', 'memo-cell', r'vd.memory[input("assign \""+cursorCol.getDisplayValue(cursorRow)+"\" to: ")] = cursorCol.getTypedValue(cursorRow)', 'store value in current cell in Memory Sheet')
+Sheet.addCommand('Alt+m', 'memo-cell', 'memo_cell()', 'store value in current cell in Memory Sheet')

visidata/tests/test_commands.py

@@ -114,6 +114,7 @@ def isTestableCommand(longname, cmdlist):
  'sheet': '',
  'col': 'Units',
  'row': '5',
+ 'memo-cell': 'rise',
  }
 
 @pytest.mark.usefixtures('curses_setup')