[types] add ipaddr and ipnet types #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle IPv4 and IPv6 addresses - Include a `select-supernets` command to select rows containing an input network
saulpw
reviewed
Jul 2, 2023
visidata/features/type_ipaddr.py
Outdated
| TableSheet.addCommand( | ||
| None, | ||
| "select-supernets", | ||
| 'cursorCol.selectSupernets(inputExpr("ip or cidr block: "))', |
There was a problem hiding this comment.
We should use input rather than inputExpr, since it's not an expression (and won't benefit from e.g. tab-completion of column names). Also let's add a type="ip" so that the history can be limited to ip addresses.
There was a problem hiding this comment.
Ah right, good call. I also need to dig into the test failures which at a glance seem to stem from assuming that ipaddress will be globally available.
There was a problem hiding this comment.
addGlobals(ipaddress=ipaddress) should cover that.
saulpw
approved these changes
Jul 2, 2023
There was a problem hiding this comment.
Looks good, thanks for putting this together, @ajkerrigan !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
select-supernetscommand to select rows containing an input networkThis is mostly a copy/paste of the example here, plus a suggestion from Saul and a couple docstrings / safety checks / style tweaks that seem to make it more suitable for inclusion in core. Suggestions for alternatives/additions/further tweaks welcome of course.
Closes #1782, and also relates to #1910