[http] fix parsing link header #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulpw
reviewed
Jun 18, 2023
| break | ||
|
|
||
| vd.status(f'fetching next page from {src}') | ||
| response = requests.get(src, stream=True, **vd.options.getall('http_req_')) |
There was a problem hiding this comment.
Hm, this is weird, were we still trying to use the requests library without importing it?
There was a problem hiding this comment.
Yes, there had previously been two lines with requests.get(), but only the first one had been changed to use urllib.request.urlopen().
|
You're right, at this point I would prefer not to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1898.
I could not reproduce the error
AttributeError: module 'urllib' has no attribute 'error'but I have attempted to patch it anyway by changing the import from urllib to urllib.error.This commit uses
requests. I am not sure if I did the import ofrequests.utilsproperly. I doimport requests.utilsbut I see there's some reason not to mix
importandvd.importExternal, and I see that it is done usingimportExternalinvisidata/visidata/loaders/scrape.py
Line 150 in fb4352c
Also I know we just got rid of most uses of requests because of a bug they refuse to fix. I am only using one simple function from it. But maybe we'd rather not use requests at all?
In any case, I have tested that this commit fixes pagination by loading
vd https://api.github.com/repos/django/django/pullswithoptions.http_max_next = 2and confirming that I see 3*30 = 90 rows.