Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose only exactly matching strings in chooser #1902

Merged
merged 2 commits into from
May 22, 2023

Conversation

daviewales
Copy link
Contributor

@daviewales daviewales commented May 16, 2023

Given a list of choices such as x, x2, x3, previously chooseMany() would select all three if you entered 'x' into the chooser input prompt.

Now it just selects the exact match 'x'. You can still select multiple values by entering them separated by spaces.

See discord conversation for context:
https://discord.com/channels/880915750007750737/880915984481939466/1107804615078072443

Given a list of choices such as x, x2, x3, previously chooseMany() would
select all three if you entered 'x' into the chooser input prompt.

Now it just selects the exact match 'x'. You can still select multiple
values by entering them separated by spaces.
Copy link
Collaborator

@anjakefala anjakefala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daviewales for opening a PR!

@anjakefala anjakefala merged commit b506348 into saulpw:develop May 22, 2023
12 checks passed
@daviewales daviewales deleted the choose-exact-matches branch July 5, 2023 02:32
anjakefala pushed a commit that referenced this pull request Jul 5, 2023
* Choose only exactly matching strings in chooser

Given a list of choices such as x, x2, x3, previously chooseMany() would
select all three if you entered 'x' into the chooser input prompt.

Now it just selects the exact match 'x'. You can still select multiple
values by entering them separated by spaces.
anjakefala pushed a commit that referenced this pull request Jul 17, 2023
* Choose only exactly matching strings in chooser

Given a list of choices such as x, x2, x3, previously chooseMany() would
select all three if you entered 'x' into the chooser input prompt.

Now it just selects the exact match 'x'. You can still select multiple
values by entering them separated by spaces.
anjakefala pushed a commit that referenced this pull request Jul 17, 2023
* Choose only exactly matching strings in chooser

Given a list of choices such as x, x2, x3, previously chooseMany() would
select all three if you entered 'x' into the chooser input prompt.

Now it just selects the exact match 'x'. You can still select multiple
values by entering them separated by spaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants