[mainloop-] draw new sheets once before execCommand

When keys were input extremely quickly, commands were running on new sheets before they could be drawn and assigned a screen.
saulpw · Apr 9, 2024 · cbb1c49 · cbb1c49
1 parent 581cdf1
commit cbb1c49
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/visidata/_input.py b/visidata/_input.py
@@ -354,6 +354,8 @@ def editText(vd, y, x, w, record=True, display=True, **kwargs):
  v = vd.getCommandInput()
 
  if v is None:
+ if vd.activeSheet._scr is None:
+ raise Exception('active sheet does not have a screen')
  try:
  v = vd.editline(vd.activeSheet._scr, y, x, w, display=display, **kwargs)
  except AcceptInput as e:

diff --git a/visidata/mainloop.py b/visidata/mainloop.py
@@ -182,7 +182,10 @@ def mainloop(vd, scr):
 
  vd.setWindows(vd.scrFull)
 
- if not vd.drainPendingKeys(scr) or time.time() - vd._lastDrawTime > vd.min_draw_ms/1000: #1459
+ # a newly created sheet needs to be drawn once to set its _scr
+ if vd.activeSheet._scr is None or \
+ not vd.drainPendingKeys(scr) or \
+ time.time() - vd._lastDrawTime > vd.min_draw_ms/1000: #1459
  vd.draw_all()
  vd._lastDrawTime = time.time()