Skip to content

Commit

Permalink
Revert "[load] error with message if dependencies are not installed" #…
Browse files Browse the repository at this point in the history
…2402

sqlalchemy was removed as dependency in ibis 9.0.  Should fix vdsql build.

This reverts commit 82dbd7f.
  • Loading branch information
saulpw committed May 16, 2024
1 parent 2cedecd commit b099224
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions visidata/apps/vdsql/_ibis.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,8 @@ def __copy__(self):
@contextmanager
def get_conn(self):
if not self.pool:
import sqlalchemy
try:
import ibis
r = ibis.connect(str(self.source))
except sqlalchemy.exc.NoSuchModuleError as e:
dialect = str(e).split(':')[-1]
vd.warning(f'{dialect} not installed')
vd.fail(f'pip install ibis-framework[{dialect}]')
import ibis
r = ibis.connect(str(self.source))
else:
r = self.pool.pop(0)

Expand Down

0 comments on commit b099224

Please sign in to comment.