Merge pull request #1960 from dbaynard/fix/zsh-completion

Fix zsh completion
saulpw · Jul 15, 2023 · 77c97a2 · 77c97a2
2 parents 3480874 + 0a65013
commit 77c97a2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -66,3 +66,5 @@ jobs:
  sudo apt install aha
  dev/mkman.sh
 
+ - name: Ensure VisiData can create completions
+ run: python -v dev/zsh-completion.py
diff --git a/dev/zsh-completion.py b/dev/zsh-completion.py
@@ -8,7 +8,6 @@
 
 sys.path.insert(0, dirn(dirn((os.path.abspath(__file__)))))
 from visidata import vd
-from visidata.main import option_aliases
 
 ZSH_COMPLETION_FILE = "_visidata"
 ZSH_COMPLETION_TEMPLATE = "dev/zsh-completion.in"
@@ -18,7 +17,9 @@
 
 def generate_completion(opt):
  prefix = "--" + opt.name
- shortnames = [key for key, value in option_aliases.items() if value[0] == opt.name]
+ shortnames = [
+ key for key, value in vd.option_aliases.items() if value[0] == opt.name
+ ]
  if len(shortnames):
  if len(shortnames[0]) == 1:
  shortname = "-" + shortnames[0]