Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom Voice and Speech Models #691

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

adrianliechti
Copy link

this pull request removes the client-side logic to verify a valid speech and voice model.
the motivation is to support custom models on openai compatible backends

thanks for considering

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (774fc9d) to head (f1994e2).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
+ Coverage   98.46%   98.66%   +0.20%     
==========================================
  Files          24       24              
  Lines        1364     1125     -239     
==========================================
- Hits         1343     1110     -233     
+ Misses         15        9       -6     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sashabaranov
Copy link
Owner

@adrianliechti thank you for the PR! I'm curious — are there any backends now that do support those?

@adrianliechti
Copy link
Author

adrianliechti commented Apr 9, 2024

@sashabaranov thanks a ton for coming back on this!
my own one adapts tools like mimic3, coqui.ai, whisper.cpp compatible ones into an openai-compatible api (also multiple ones). here a link: https://github.com/adrianliechti/llama. It is in use as part of a commercial platform at my employer.
and since I was using your lovely SDK for both tests but also integration, I allowed me to create this PR.

I think it is in line with this project's recent changes on embedding/models - so I hope over time a broader audience benefits (or at least needs less urgent maintenance once openai releases new whisper or tts models)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants