Skip to content

Commit

Permalink
Merge pull request cri-o#8247 from saschagrunert/notes-fail
Browse files Browse the repository at this point in the history
Don't fail CI on GitHub pages push
  • Loading branch information
openshift-merge-bot[bot] committed Jun 4, 2024
2 parents 9b9452f + ef7880d commit d249d32
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion scripts/release-notes/release_notes.go
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,11 @@ To verify the bill of materials (SBOM) in [SPDX](https://spdx.org) format using
const maxRetries = 10
for i := 0; i <= maxRetries; i++ {
if err := command.New("git", "pull", "--rebase").RunSuccess(); err != nil {
return fmt.Errorf("pull and rebase from remote: %w", err)
logrus.Errorf("Pull and rebase from remote failed (skipping): %v", err)
// A failed release notes GitHub pages update is not critical and
// we need the release notes as part of the next CI step to
// actually create the release.
return nil
}

err := repo.Push(branch)
Expand Down

0 comments on commit d249d32

Please sign in to comment.