100 clone generate rsp #116
Conversation
mem/vm/protocol.go
Outdated
|
|
||
| // GenerateRsp generates response to originral translation request | ||
| func (r *TranslationReq) GenerateRsp(page Page) sim.Rsp { | ||
| rsp := TranslationRspBuilder{}.WithSrc(r.Dst).WithDst(r.Src).WithRspTo(r.ID).WithPage(page).Build() |
There was a problem hiding this comment.
Write in multiple lines to avoid long lines.
| @@ -18,6 +18,11 @@ func (m *TrafficMsg) Meta() *sim.MsgMeta { | |||
| return &m.MsgMeta | |||
| } | |||
|
|
|||
| // Clone returns cloned TrafficMsg | |||
| func (m *TrafficMsg) Clone() sim.Msg { | |||
There was a problem hiding this comment.
We need to really clone it rather than just return the pointer.
| } | ||
|
|
||
| func (p *PingMsg) GenerateRsp() sim.Rsp { | ||
| rsp := &PingRsp{} |
There was a problem hiding this comment.
We should need a new ID, right?
sim/examples/ping/comp.go
Outdated
| } | ||
|
|
||
| func (p *PingRsp) GetRspTo() string { | ||
| return strconv.Itoa(p.SeqID) |
There was a problem hiding this comment.
Does the request have an ID? If so, we need to get the request ID. If not, we need to add the ID to the request.
| @@ -3,6 +3,8 @@ package sim | |||
| // A Msg is a piece of information that is transferred between components. | |||
| type Msg interface { | |||
| Meta() *MsgMeta | |||
| Clone() Msg | |||
| // GenerateRsp() Rsp | |||
There was a problem hiding this comment.
It is good that you do not add a GenerateRsp as a required field. A recommendation is that you can have two extra interfaces, Request and Response. The Request can have GenerateRsp method and the Response can have the GetRspTo method.
| @@ -72,6 +72,10 @@ func (m *sampleMsg) Meta() *MsgMeta { | |||
| return &m.MsgMeta | |||
| } | |||
|
|
|||
| func (m *sampleMsg) Clone() Msg { | |||
There was a problem hiding this comment.
Same here, if it is not difficult to clone the message, why not using the code below?
func (c *ControlMsg) Clone() Msg {
cloneMsg := *c
cloneMsg.ID = GetIDGenerator().Generate()
return &cloneMsg
}
No description provided.