do not print parent task is parent task is finished.

sarchlab · Apr 26, 2024 · ddfee9a · ddfee9a
1 parent 898b9e4
commit ddfee9a
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/tracing/backtracetracer.go b/tracing/backtracetracer.go
@@ -63,5 +63,10 @@ func (t *BackTraceTracer) DumpBackTrace(task Task) {
  return
  }
 
- t.DumpBackTrace(t.tracingTasks[task.ParentID])
+ parentTask, ok := t.tracingTasks[task.ParentID]
+ if !ok {
+ return
+ }
+
+ t.DumpBackTrace(parentTask)
 }
diff --git a/tracing/backtracetracer_test.go b/tracing/backtracetracer_test.go
@@ -94,4 +94,17 @@ var _ = Describe("BackTraceTracer", func() {
 
  t.DumpBackTrace(Task{ID: "3", ParentID: "2"})
  })
+
+ It("should print three tasks", func() {
+ t.StartTask(Task{ID: "1"})
+ t.StartTask(Task{ID: "2", ParentID: "1"})
+ t.StartTask(Task{ID: "3", ParentID: "2"})
+
+ t.EndTask(Task{ID: "2", ParentID: "1"})
+
+ mockTaskPrinter.EXPECT().
+ Print(Task{ID: "3", ParentID: "2"})
+
+ t.DumpBackTrace(Task{ID: "3", ParentID: "2"})
+ })
 })