Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): turn off "require dashboard approval" renovatebot req #5199

Closed
wants to merge 1 commit into from

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Nov 15, 2023

Description

Enables Renovatebot to open PRs without requiring approving the PR on #4030

Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Nov 15, 2023 9:18am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 9:18am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 9:18am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Nov 15, 2023 9:17 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 15s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 3s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 6s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 16s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 8s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 39s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 6s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 3s 3 0 0

@jtpetty
Copy link
Contributor

jtpetty commented Dec 18, 2023

@stipsan - I'm not sure I fully understand what this PR does.

@binoy14
Copy link
Contributor

binoy14 commented Dec 19, 2023

Have a few concerns regarding this

  1. This would create a lot of PRs hogging vercel builds org wide. Can we limit the number of PRs it creates
  2. Does it make sense to change the rebase strategy to only do it when conflicted instead of behind base so avoid the above issue
  3. We need first fix the dataset creation issue with cli tests before introducing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants