Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typeEvaluator): add support for array functions #236

Merged
merged 1 commit into from
May 15, 2024
Merged

feat(typeEvaluator): add support for array functions #236

merged 1 commit into from
May 15, 2024

Conversation

sgulseth
Copy link
Member

No description provided.

@sgulseth sgulseth requested a review from a team May 15, 2024 10:34
judofyr
judofyr approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@judofyr judofyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still struggle with understanding the impact of nested mapConcrete, but (1) this looks correct and (2) tests are passing.

@sgulseth sgulseth merged commit 86b1053 into main May 15, 2024
9 checks passed
@sgulseth sgulseth deleted the feat/array-funcs branch May 15, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@judofyr judofyr judofyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgulseth @judofyr