Handle not nodes when resolving conditions #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgulseth
force-pushed
the
fix/resolve-not-conditions
branch
from
0c46cc8
to
f350ba7
Compare
sgulseth
changed the title
judofyr
reviewed
May 3, 2024
src/typeEvaluator/typeEvaluate.ts
Outdated
| return value.value | ||
| } | ||
|
|
||
| return false |
There was a problem hiding this comment.
I'm not sure if this makes sense for AccessAttribute. E.g. if evaluating AccessAttribute returns unknown then we want to return undefined.
Also: Can't resolveCondition just be like this? 🤔
const value = walk({node: expr, scope})
if (value.type === 'boolean') return value.value
if (value.type === 'null') return false
return undefinedAnd then we depend on the regular walk function to handle the different operators?
There was a problem hiding this comment.
Agree on returning undefined on unknown!
We would need to refactor it a bit as handleOpCall depends on resolveCondition 🤔 - I can have a look outside this PR?
There was a problem hiding this comment.
Hm. This doesn't seem to have been addressed in the latest re-review? 🤔
There was a problem hiding this comment.
Updated it to default to undefined but also return false on array, object, null
sgulseth
force-pushed
the
fix/resolve-not-conditions
branch
6 times, most recently
from
ed9b958
to
184eb8a
Compare
sgulseth
force-pushed
the
fix/resolve-not-conditions
branch
from
184eb8a
to
aee1e8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.