quality of life improvements #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgulseth
force-pushed
the
feat/upgrade-groq
branch
from
4d12457
to
b37a490
Compare
sgulseth
force-pushed
the
feat/upgrade-groq
branch
from
b37a490
to
ef03c45
Compare
j33ty
approved these changes
Mar 18, 2024
| }, | ||
| "scripts": { | ||
| "test": "eslint ." | ||
| "test": "echo '[{\"foo\": 1}]' | ./bin/groq.js --pretty '*[]{ foo }'", |
There was a problem hiding this comment.
Nit: Shall we move it out of package.json and to a file instead?
There was a problem hiding this comment.
Ideally I would want to create some proper tests 😅 This was just the path of least resistance for now
tzhelyazkova
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Need to change master branch to main before merge)