Cluster mode support #420
Draft
Cluster mode support #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
reviewed
Apr 1, 2024
There was a problem hiding this comment.
overall seems like a reasonable feature, but there's a fair bit to clear up here.
Should we wait to add cluster support until after #437?
| options: --entrypoint redis-server | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Test redis cluster |
There was a problem hiding this comment.
I think we should add cluster tests separately from the main tests as redis-cluster-test.
|
|
||
| from .constants import default_queue_name, expires_extra_ms, job_key_prefix, result_key_prefix | ||
| from .jobs import Deserializer, Job, JobDef, JobResult, Serializer, deserialize_job, serialize_job | ||
| from .utils import timestamp_ms, to_ms, to_unix_ms | ||
|
|
||
| logger = logging.getLogger('arq.connections') | ||
| logging.basicConfig(level=logging.DEBUG) |
There was a problem hiding this comment.
Suggested change
| logging.basicConfig(level=logging.DEBUG) |
| @@ -27,7 +33,7 @@ class RedisSettings: | |||
| Used by :func:`arq.connections.create_pool` and :class:`arq.worker.Worker`. | |||
| """ | |||
|
|
|||
| host: Union[str, List[Tuple[str, int]]] = 'localhost' | |||
| host: Union[str, List[Tuple[str, int]]] = 'test-cluster.aqtke6.clustercfg.use2.cache.amazonaws.com' | |||
There was a problem hiding this comment.
Suggested change
| host: Union[str, List[Tuple[str, int]]] = 'test-cluster.aqtke6.clustercfg.use2.cache.amazonaws.com' | |
| host: Union[str, List[Tuple[str, int]]] = 'localhost' |
Comment on lines
+177
to
+179
| the_job = Job(job_id, redis=self, _queue_name=_queue_name, _deserializer=self.job_deserializer) | ||
| logger.debug(the_job) | ||
| return the_job |
| class ArqRedisCluster(RedisCluster): # type: ignore | ||
| """ | ||
| Thin subclass of ``from redis.asyncio.cluster.RedisCluster`` which patches methods of RedisClusterPipeline | ||
| to support redis cluster`. |
There was a problem hiding this comment.
Suggested change
| to support redis cluster`. | |
| to support redis cluster. |
| @@ -299,5 +391,5 @@ async def log_redis_info(redis: 'Redis[bytes]', log_func: Callable[[str], Any]) | |||
| f'redis_version={redis_version} ' | |||
| f'mem_usage={mem_usage} ' | |||
| f'clients_connected={clients_connected} ' | |||
| f'db_keys={key_count}' | |||
| f'db_keys={88}' | |||
| @@ -59,7 +59,7 @@ Changelog = 'https://github.com/samuelcolvin/arq/releases' | |||
| testpaths = 'tests' | |||
| filterwarnings = ['error'] | |||
| asyncio_mode = 'auto' | |||
| timeout = 10 | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds limited support for redis cluster mode. This was done by overwriting a few methods when
RedisSettingshas the newcluster_modeflag on.