-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Sam Potts
committed
May 16, 2017
1 parent
4957e4d
commit bcf88cd
Showing
11 changed files
with
92 additions
and
49 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
### Link to related issue (if applicable) | ||
### Link to related issue (if applicable) | ||
|
||
### Sumary of proposed changes | ||
### Sumary of proposed changes | ||
|
||
### Task list | ||
|
||
- [ ] Tested on [supported browsers](https://github.com/Selz/plyr#browser-support) | ||
- [ ] Gulp build completed | ||
- [ ] Tested on [supported browsers](https://github.com/sampotts/plyr#browser-support) | ||
- [ ] Gulp build completed |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
### Todo | ||
|
||
#### To build | ||
[x] Get list of subtitles/captions available (HTML5, Vimeo) | ||
[x] Add preferred quality option into config | ||
[ ] Update quality options on YouTube play (can't get up front?!) | ||
[ ] Update speed options on YouTube load | ||
[ ] Finish and test PiP (need MacOS Sierra) | ||
[ ] Finish and test AirPlay (need MacOS Sierra) | ||
[ ] Controls hide/show events | ||
[ ] Test custom controls still works | ||
[ ] Tidy up small UI for iOS inline | ||
[ ] Finish new loop setup and UI | ||
[ ] Toggle settings menu | ||
|
||
#### Later | ||
[ ] Get quality options for HTML5 somehow (multi source?) | ||
[ ] Download button - grab first <source> or src attribute (or maybe use currentSrc?) for HTML5 and links for embedded players | ||
|
||
#### Bugs | ||
[ ] Fix audio setup bug when calling `.setup()` again | ||
[ ] Fix events on unsupported devices (iOS, old IE) | ||
[x] Fix YouTube rights blocking (origin perhaps?) | ||
|
||
# Notes | ||
- No quality HTML5 support (yet) | ||
- No Vimeo quality support | ||
- No YouTube caption support | ||
- Added Vimeo captions support | ||
- No PiP or AirPlay for Vimeo/YouTube | ||
- Settings won't be supported for custom controls (coming soon, need to work on templating) | ||
- Added `playsinline` support for iOS 10 | ||
- Embed setup now accept an <iframe> as the target element for true progressive enhancement | ||
|
||
#### Breaking changes | ||
- New config options for loop | ||
- Selectors changes (new `input` and `display` object) - DOCUMENT | ||
- Custom HTML option now `controls` which accepts a string (HTML), a function (your own template engine) or array (use built in controls) | ||
- .setup() is removed in favour of a constructor | ||
|
||
## Added | ||
- Seek i8n label | ||
- Loop related i8n labels |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.