[WIP] Read-only Replica #879
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderkiel
force-pushed
the
read-only-replika
branch
from
07df8fa
to
1d06a03
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #879 +/- ##
========================================
Coverage 94.02% 94.03%
========================================
Files 235 234 -1
Lines 14763 14783 +20
Branches 378 378
========================================
+ Hits 13881 13901 +20
Misses 504 504
Partials 378 378
|
Before that change the transaction log API handled only resource hashes instead of whole resources. The resources itself had to be handled outside of the transaction log. Now the API of the transaction log takes resources instead of hashes. Internally the local and the Kafka implementation still use the resource store in order to transport the resources out-of-band so that the transaction log storage itself doesn't have to contain the whole resources. This change enables transaction log implementations that transport the resources in-band and so don't need a resource store. At least not for the resources that are not already indexed. This change is fully compatible with the current storage model and so is a pure refactoring.
alexanderkiel
force-pushed
the
read-only-replika
branch
from
1d06a03
to
be4eacc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare Transaction Log API to Transport Resources
Before that change the transaction log API handled only resource hashes instead of whole resources. The resources itself had to be handled outside of the transaction log.
Now the API of the transaction log takes resources instead of hashes. Internally the local and the Kafka implementation still use the resource store in order to transport the resources out-of-band so that the transaction log storage itself doesn't have to contain the whole resources.
This change enables transaction log implementations that transport the resources in-band and so don't need a resource store. At least not for the resources that are not already indexed.
This change is fully compatible with the current storage model and so is a pure refactoring.