Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate KvIterator from Protocol to Interface #676

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

alexanderkiel
Copy link
Member

Protocol dispatch isn't as fast as interface dispatch and primitive types are not possible on protocols.

Protocol dispatch isn't as fast as interface dispatch and primitive
types are not possible on protocols.
@alexanderkiel alexanderkiel self-assigned this Apr 7, 2022
@alexanderkiel alexanderkiel added the performance Performance improvement label Apr 7, 2022
@alexanderkiel alexanderkiel added this to the v0.16.5 milestone Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #676 (dca4e44) into develop (11e66b2) will decrease coverage by 0.09%.
The diff coverage is 67.64%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #676      +/-   ##
===========================================
- Coverage    93.60%   93.51%   -0.10%     
===========================================
  Files          235      235              
  Lines        13921    13918       -3     
  Branches       345      349       +4     
===========================================
- Hits         13031    13015      -16     
- Misses         545      554       +9     
- Partials       345      349       +4     
Impacted Files Coverage Δ
modules/kv/src/blaze/db/kv.clj 82.35% <35.71%> (-17.65%) ⬇️
modules/db/src/blaze/db/impl/iterators.clj 94.28% <83.33%> (-5.72%) ⬇️
...ules/db/src/blaze/db/impl/index/resource_as_of.clj 97.63% <100.00%> (ø)
modules/kv/src/blaze/db/kv/mem.clj 100.00% <100.00%> (ø)
modules/rocksdb/src/blaze/db/kv/rocksdb.clj 99.04% <100.00%> (ø)

@alexanderkiel alexanderkiel removed this from the v0.16.5 milestone Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant