Fix ContainerHighCpuUtilization - it originally warns if a container uses 0.8 core, this PR makes it warn if it uses 80% of cgroup cpu limit
#367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kariton
reviewed
Aug 7, 2023
| @@ -350,7 +350,7 @@ groups: | |||
| This rule can be very noisy in dynamic infra with legitimate container start/stop/deployment. | |||
| - name: Container High CPU utilization | |||
| description: Container CPU utilization is above 80% | |||
| query: '(sum(rate(container_cpu_usage_seconds_total{name!=""}[3m])) BY (instance, name) * 100) > 80' | |||
| query: '(sum(rate(container_cpu_usage_seconds_total{pod!=""}[3m])) by (instance, pod) / sum(container_spec_cpu_quota / container_spec_cpu_period) by (instance, pod) * 100) > 80' | |||
There was a problem hiding this comment.
FYI:
i am running container with docker and the metric from cadvisor does not have the label "pod" on my instance.
There was a problem hiding this comment.
Are you running containers in k8s ?
In my setup, out of k8s, I see "name" instead of "pod".
There was a problem hiding this comment.
(I am running in k8s; not knowing what @Kariton is running on)
There was a problem hiding this comment.
Looks like i need to clarify. 馃槃
I run it on docker - not k8s.
I know that someone could run docker under the hood of k8s.
but i run just a straight up plain docker instance.
There was a problem hiding this comment.
so i also have "name" instead of "pod".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.