New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] feat: Improve macOS defaults support #66466
Open
cdalvaro
wants to merge
4
commits into
saltstack:master
Choose a base branch
from
cdalvaro:enhancement/improve_macOS_defaults_support
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[master] feat: Improve macOS defaults support #66466
cdalvaro
wants to merge
4
commits into
saltstack:master
from
cdalvaro:enhancement/improve_macOS_defaults_support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
feat: Improve macOS defaults support
[master] feat: Improve macOS defaults support
May 5, 2024
cdalvaro
force-pushed
the
enhancement/improve_macOS_defaults_support
branch
from
May 8, 2024 09:16
5ac919d
to
290b097
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve macOS defaults support by adding typecasting as well as dictionaries and arrays parsing.
Previous Behavior
Dictionaries and arrays were not supported.
New Behavior
Now you can set dictionaries and arrays, and support for floats and integers values has been improved.
Some examples that works now:
The recipe Rectangle - Almost Maximize height didn't work because when comparing the current value with the new one, the new one was a float and the retrieved by
macdefaults.read
was a string. Thus, the comparison doesn't match.The recipe Rectangle - Almost Maximize shortcut was not working at all. The write command wasn't formed well. And the output retrieved by
macdefaults.read
was not parsed into a Python dictionary, so comparison always fails.Other recipes that works now:
Values are typecasted when possible, so some formulas may need to be adapted to be idempotent.
The
type
parameter in themacdefaults.write
method has been deprecated in favor ofvtype
. This makes the state and the module coherent and avoids the collision between the parameter and the built-intype()
Python function.The
type
parameter should be removed in version3009
.Merge requirements satisfied?
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.