[3006.x] Fix #66133: roots fileserver path verification for symlinks #66419
+51
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwoz
requested changes
Apr 22, 2024
hurzhurz
force-pushed
the
3006.x-roots-symlink
branch
from
d3fbb96
to
4819ce7
Compare
hurzhurz
force-pushed
the
3006.x-roots-symlink
branch
from
4819ce7
to
dbc109e
Compare
|
I thought about that but wasn't sure if I should touch the function. |
twangboy
approved these changes
Apr 23, 2024
|
Yes, I like this approach better. Please hold off on merging this. I have a few things I would like to validate before we proceed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes of the path verification so that symlinks to destinations outside of the roots directory work again.
This is broken since the CVE fix commit e0cdb80.
What issues does this PR fix or reference?
Fixes #66133, #66052, #65977