[3006.x] Fix #66382 (nftables): Produce correct ip family for rules with saddr or daddr #66383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
jdelic
force-pushed
the
fix/issue66382-nftables
branch
3 times, most recently
from
8ffc99c
to
2c5d6ff
Compare
|
this should be against 3006.x or 3007.x if it is happening in those versions. can you rebase this fix to those versions. |
|
@whytewolf I totally can. Should I close this one then? |
salt-project-bot-prod-environment
bot
changed the title
salt-project-bot-prod-environment
bot
changed the title
|
Actually, let me try to change that in place |
jdelic
force-pushed
the
fix/issue66382-nftables
branch
from
2c5d6ff
to
15be35c
Compare
salt-project-bot-prod-environment
bot
changed the title
jdelic
force-pushed
the
fix/issue66382-nftables
branch
from
15be35c
to
116cea3
Compare
|
@whytewolf |
we will merge it forward to handle that. |
whytewolf
previously approved these changes
Apr 17, 2024
…ith saddr or daddr
jdelic
force-pushed
the
fix/issue66382-nftables
branch
from
116cea3
to
2eedc09
Compare
|
@whytewolf |
whytewolf
approved these changes
Apr 17, 2024
s0undt3ch
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes nftables.build_rule so that it adds the correct family identifier to rules containing
saddrordaddrparts.What issues does this PR fix or reference?
Fixes #66382
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes