Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature | Added support to Response object method to now accept a dot notation like json() #420

Merged
merged 9 commits into from
Jun 9, 2024
Merged

Feature | Added support to Response object method to now accept a dot notation like json() #420

merged 9 commits into from
Jun 9, 2024

Conversation

Braunson
Copy link
Contributor

@Braunson Braunson commented May 23, 2024 •
edited

  • Added support to Response object method to now accept a dot notation like json()
  • Fixed grammar issue
  • Added a new ObjectHelpers class
  • Added test related to retrieving nested array in object via dot notation key
  • Should be backward compatible

Related to #418

@Sammyjo20 Sammyjo20 changed the title [Feature] Added support to Response object method to now accept a dot notation like json() Featue | Added support to Response object method to now accept a dot notation like json() Jun 9, 2024
@Sammyjo20 Sammyjo20 changed the title Featue | Added support to Response object method to now accept a dot notation like json() Featur | Added support to Response object method to now accept a dot notation like json() Jun 9, 2024
@Sammyjo20 Sammyjo20 changed the title Featur | Added support to Response object method to now accept a dot notation like json() Feature | Added support to Response object method to now accept a dot notation like json() Jun 9, 2024
Sammyjo20
Sammyjo20 approved these changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution, thanks @Braunson!

@Sammyjo20 Sammyjo20 merged commit 29ced5f into saloonphp:v3 Jun 9, 2024
14 checks passed
@Sammyjo20 Sammyjo20 mentioned this pull request Jun 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sammyjo20 Sammyjo20 Sammyjo20 approved these changes

@patrickcarlohickman patrickcarlohickman Awaiting requested review from patrickcarlohickman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Braunson @patrickcarlohickman @Sammyjo20