Migrate Transaction Refund Datagrid to GridTable #4855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 880a9b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…-to-dashboardtable
Droniu
changed the title
Droniu
changed the title
…-to-dashboardtable
Cloud11PL
previously approved these changes
May 15, 2024
...TransactionRefundPage/components/OrderTransactionRefundTable/OrderTransactionRefundTable.tsx
Outdated
Show resolved
Hide resolved
src/orders/views/OrderTransactionRefundCreate/OrderTransactionRefundCreate.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
86
to
96
| const toAdd = linesToRefund.reduce<OrderGrantRefundUpdateLineAddInput[]>((acc, line, ix) => { | ||
| if (typeof line.quantity === "number" && line.quantity > 0) { | ||
| acc.push({ | ||
| id: data.order!.lines[ix].id, | ||
| quantity: line.quantity, | ||
| reason: line.reason, | ||
| }); | ||
| } | ||
|
|
||
| return acc; | ||
| }, []) ?? []; | ||
| return acc; | ||
| }, []); |
There was a problem hiding this comment.
Suggestion: It seems like we can just filter and/or map on linesToRefund here
There was a problem hiding this comment.
@Cloud11PL I needed to change back to reduce here because using filter & map changes the indices I rely upon to get proper line IDs
andrzejewsky
previously approved these changes
May 15, 2024
...TransactionRefundPage/components/OrderTransactionRefundTable/OrderTransactionRefundTable.tsx
Outdated
Show resolved
Hide resolved
src/orders/views/OrderTransactionRefundCreate/OrderTransactionRefundCreate.tsx
Outdated
Show resolved
Hide resolved
…-to-dashboardtable
poulch
reviewed
May 16, 2024
src/orders/components/OrderTransactionRefundPage/OrderTransactionRefundPage.tsx
Outdated
Show resolved
Hide resolved
...TransactionRefundPage/components/OrderTransactionReasonModal/OrderTransactionReasonModal.tsx
Outdated
Show resolved
Hide resolved
.../OrderTransactionRefundPage/components/OrderTransactionRefundTable/AlreadyRefundedHelper.tsx
Outdated
Show resolved
Hide resolved
...TransactionRefundPage/components/OrderTransactionRefundTable/OrderTransactionRefundTable.tsx
Outdated
Show resolved
Hide resolved
Cloud11PL
previously approved these changes
May 17, 2024
…-to-dashboardtable
poulch
reviewed
May 18, 2024
.../OrderTransactionRefundPage/components/OrderTransactionRefundTable/AlreadyRefundedHelper.tsx
Outdated
Show resolved
Hide resolved
poulch
reviewed
May 18, 2024
...sactionRefundPage/components/OrderTransactionRefundTable/OrderTransactionRefundTableLine.tsx
Outdated
Show resolved
Hide resolved
andrzejewsky
approved these changes
May 20, 2024
Cloud11PL
approved these changes
May 20, 2024
Droniu
deleted the
merx-360-migrate-transaction-refund-datagrid-to-dashboardtable
branch
karola312
pushed a commit
that referenced
this pull request
May 23, 2024
* (wip) Migrate Transaction Refund Datagrid to GridTable * Add changeset * UI improvements & reason per line modal * Fix strict mode * Refactor * CR Refactor * Improve modal UI * Strict mode fix * Fix navigation * CR improvements * Fix qtyToRefund == maxQtyToRefund * Split components & handle ellipsis better * Fix incorrect handling of refund lines * Fix refs type errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description
Enable this feature with:
Go to order with at least one transaction, and create a new refund