Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

998 Passwordless login #1253

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

998 Passwordless login #1253

wants to merge 5 commits into from

Conversation

vimark1
Copy link

@vimark1 vimark1 commented Aug 30, 2023

fixes #998

  • This is mostly based on the password reset token
  • The token lasts 5 minutes
  • If an account is not found, the user sees a vague message "If the email address you entered exists, you will receive a magic link shortly.". This is to prevent the app from disclosing wether an email exists or not. See https://cheatsheetseries.owasp.org/cheatsheets/Authentication_Cheat_Sheet.html#authentication-and-error-messages
  • It will verify the user's email on their first successful login
  • The magic login link respects the returnTo session data. So it will return to the requested page after login
  • Contents of the email is printed to console in development mode for ease of use and testing

@vimark1
Copy link
Author

vimark1 commented Sep 26, 2023

Sorry to ping @YasharF but I spent a lot of time on these contributions and they haven't been reviewed. Happy to help with reviews if I be added as a member of this project. Thank you

@YasharF
Copy link
Collaborator

YasharF commented Oct 2, 2023

The implementation isn't quite what I was envisioning, hence I need to put some thought into it. At the same time I have a high priority GPT project that I am working on, so it is going to take some time for me to get thru this.

@vimark1
Copy link
Author

vimark1 commented Feb 23, 2024

Any updates on this @YasharF ?

@vimark1
Copy link
Author

vimark1 commented Mar 28, 2024

Keen to get this merged through @YasharF - what are the changes I am required to make?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Passwordless login
3 participants