-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run passing tests from pjdfstest #1882
base: master
Are you sure you want to change the base?
Conversation
autogen.sh
Outdated
@@ -38,6 +38,8 @@ aclocal \ | |||
&& automake --add-missing \ | |||
&& autoconf | |||
|
|||
(cd test/pjdfstest && autoreconf -ifs && ./configure) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any ideas on what is the correct way to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting pjdfstest as a submodule is a bit thoughtful.
I want the s3fs repository to be able to work independently.
I don't think I agree with mixing the pjdfstest build with the s3fs build.
The pjdfstest build is the environment
required for the s3fs build(and test), and I think it's better to separate this part.
If you want to use pjdfstest in s3fs test, what about the following method?
- In github actions, git clone pjdfstest under the test directory(this can be done with ci.yml. You can prepare a helper script if necessary)
- And in the pjdfstest directory, do that build
How about performing this step only during CI?
Anyone can deploy it on localhost other than CI by preparing a dedicated helper script.
(Alternatively, you may prepare another repository(ex. s3fs-fuse/s3fs-pjdfstest, etc.) and dedicate it. But this is still an idea I just come up with, so it may be wrong.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came up with another one.
You may want to call the script as a PHONY target in the Makefile (.am)
of the test directory.
(Clone and build pjdfstest in the script)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a example. (see proto_pjdfstest branch in my personal repo)
ggtakec/s3fs-fuse@master...proto_pjdfstest
I haven't implemented a "test" using pjdfstest yet...(because I don't know how you want to do it)
This way, pjdfstest can be made independent for now, which is in line with my wishes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reworked this to download the tarball which is cleaner.
804e924
to
d86ca1a
Compare
This seems to show some real failure with |
This increases CI run-time by 50% so we should be careful if we want to merge this PR. |
This downloads a tarball by hash instead of using a submodule. References s3fs-fuse#1589.
CI recently started failing with these kinds of errors:
I don't think they are related to this PR. |
This downloads a tarball by hash instead of using a submodule.
References #1589.