Use specific exceptions catching

s0md3v · Aug 8, 2023 · 622513a · 622513a
1 parent d0bfd1a
commit 622513a
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/roop/utilities.py b/roop/utilities.py
@@ -26,9 +26,8 @@ def run_ffmpeg(args: List[str]) -> bool:
  try:
  subprocess.check_output(commands, stderr=subprocess.STDOUT)
  return True
- except Exception:
- pass
- return False
+ except subprocess.CalledProcessError:
+ return False
 
 
 def detect_fps(target_path: str) -> float:
@@ -37,9 +36,8 @@ def detect_fps(target_path: str) -> float:
  try:
  numerator, denominator = map(int, output)
  return numerator / denominator
- except Exception:
- pass
- return 30
+ except (ValueError, ZeroDivisionError):
+ return 30
 
 
 def extract_frames(target_path: str, fps: float = 30) -> bool: