Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve example code demonstrating Interface Segregation Principle. #377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cpressey
Copy link

Hello. This is a useful resource.

When reading the section on the Interface Segregation Principle it occurred to me that the code section could give a stronger and clearer example. The principle is "Clients should not be forced to depend upon interfaces that they do not use." Even knowing about the existence is a dependency, and it can be avoided in this case. There is no reason for the client code to even know that animationModule exists or that DOMTraverser cares about it.

(This sort of thing happens frequently in practice; e.g. if animationModule is added to a new version of DOMTraverser, old client code will not know about it, and making it optional in this way avoids having to update those calls.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant