Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is WIP to upgrade the dependency on
onmt
from a the forked version to latest v.3.5.1 dropping the need of a fork.And also upgrading to python 3.11
Changes made:
Preprocessing
Running
rxn-onmt-preprocess
throws an error about/bin/bash command onmt_preprocess not found
. This comes from this line. Theonmt_preprocess
functionality was dropped by OpenNMT from v.1.2.0 -> v.2.2.0Solution: changes can be found in
src/rxn/onmt_models/scripts/rxn_onmt_preprocess.py
by upgrading the command toonmt_build_vocab
here and a helper wrapper function here. The use ofonmt_build_vocab
is used all over the official docsTraining
The idea is to still call on cli
onmt_train -config /path/to/config.yaml
viarun_command()
but in a way such that it resembles as much as possible the official way here.Turns out we only need to: instead of passing
onmt_train -- <all arguments>
we dump the arguments thatrxn-onmt-train
receives via cli to aconfig.yaml
in the same way OpenNMT v.3.5.1 expects them.Solution: changes can be found in
src/rxn/onmt_models/scripts/rxn_onmt_train.py
added a wrapper function here because OpenNMT v.3.5.1 expectssrc_vocab
andtgt_vocab
in config file. See #PR (TODO) inrxn-onmt-utils
for changes in classOnmtTrainCommand