Auto merge of #12700 - Luv-Ray:overly_complex_bool_expr, r=Jarcho

[`overly_complex_bool_expr`]: Fix trigger wrongly on never type

fixes #12689

---

changelog: fix [`overly_complex_bool_expr`] triggers wrongly on never type

clippy_lints/src/booleans.rs

@@ -251,6 +251,11 @@ impl<'a, 'tcx, 'v> Hir2Qmm<'a, 'tcx, 'v> {
  _ => (),
  }
  }
+
+ if self.cx.typeck_results().expr_ty(e).is_never() {
+ return Err("contains never type".to_owned());
+ }
+
  for (n, expr) in self.terminals.iter().enumerate() {
  if eq_expr_value(self.cx, e, expr) {
  #[expect(clippy::cast_possible_truncation)]

tests/ui/overly_complex_bool_expr.fixed

@@ -37,3 +37,13 @@ fn check_expect() {
  #[expect(clippy::overly_complex_bool_expr)]
  let _ = a < b && a >= b;
 }
+
+#[allow(clippy::never_loop)]
+fn check_never_type() {
+ loop {
+ _ = (break) || true;
+ }
+ loop {
+ _ = (return) || true;
+ }
+}

tests/ui/overly_complex_bool_expr.rs

@@ -37,3 +37,13 @@ fn check_expect() {
  #[expect(clippy::overly_complex_bool_expr)]
  let _ = a < b && a >= b;
 }
+
+#[allow(clippy::never_loop)]
+fn check_never_type() {
+ loop {
+ _ = (break) || true;
+ }
+ loop {
+ _ = (return) || true;
+ }
+}