Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add toggle_async_sugar assist code action #17258

Merged
merged 3 commits into from
May 27, 2024

Conversation

maxwase
Copy link
Contributor

@maxwase maxwase commented May 18, 2024

Implement code action for sugaring and de-sugaring asynchronous functions.

This code action does not import Future trait when de-sugaring and does not touch function boby, I guess this can be implemented later if needed. This action also does not take into consideration other bounds because IMO it's usually "let me try to use sugared version here".

Feel free to request changes, that's my first code action implementation 😄

Closes #17010
Relates to #16195

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2024
@maxwase maxwase force-pushed the code-assist-async-sugar branch 3 times, most recently from d0192ee to 723adc7 Compare May 18, 2024 17:11
@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 23, 2024

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust-analyzer.git master
$ git push --force-with-lease

The following commits are merge commits:

@maxwase maxwase requested a review from Veykril May 23, 2024 23:29
@Veykril Veykril added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 27, 2024
@Veykril
Copy link
Member

Veykril commented May 27, 2024

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented May 27, 2024

📌 Commit 61f8ef5 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 27, 2024

⌛ Testing commit 61f8ef5 with merge b32f181...

@bors
Copy link
Collaborator

bors commented May 27, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing b32f181 to master...

@bors bors merged commit b32f181 into rust-lang:master May 27, 2024
11 checks passed
@maxwase maxwase deleted the code-assist-async-sugar branch May 27, 2024 19:41
@lnicola lnicola changed the title Add toggle_async_sugar assist code action feat: Add toggle_async_sugar assist code action Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code action to toggle async fn and impl Future
4 participants