Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N46: seldom_state #1383

Merged
merged 5 commits into from
Jun 12, 2023
Merged

N46: seldom_state #1383

merged 5 commits into from
Jun 12, 2023

Conversation

Seldom-SE
Copy link
Contributor

Part of #1378

Thanks!

@Seldom-SE
Copy link
Contributor Author

I forgot to follow some of the style guidelines! I'll fix it tomorrow probably

@Seldom-SE Seldom-SE marked this pull request as draft June 8, 2023 19:03
@ozkriff
Copy link
Member

ozkriff commented Jun 9, 2023

Speaking about style: the current update description feels too low-level for the newsletter's format - may I ask you to compress it into a more high-level overview and give a link to https://github.com/Seldom-SE/seldom_state/blob/main/CHANGELOG.md#06-2023-05-07 for folks who want to dive into API/signature-level of detail?

Also, please try to avoid using long code blocks - they're usually hard to read on mobile devices.

@Seldom-SE Seldom-SE marked this pull request as ready for review June 10, 2023 01:13
@Seldom-SE
Copy link
Contributor Author

Ok, ready!

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ozkriff ozkriff changed the title N46: seldom_state N46: seldom_state Jun 12, 2023
@ozkriff ozkriff merged commit 2c08678 into rust-gamedev:source Jun 12, 2023
1 check passed
@ozkriff
Copy link
Member

ozkriff commented Jun 12, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants