registers_with_uniq_names #216
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to add more remedies to get valid code generated from this .svd file. Suggestions for improving this PR are welcome! |
|
Adding |
|
Ping from triage: @astro are you still looking for improvement idea ? |
mathk
added
the
S-waiting-on-author
|
@mathk That would be helpful. |
|
If this is still actual, please rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a proposal to solve one more issue I found in the LPC13xx .svd file: registers with duplicate names.
This PR does not simply drop the duplicate identifiers but tries to rename them by appending
2, or3, and so on.