Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid world-writable devices in udev rules #525

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgeisler
Copy link

This came out of a discussion in Comprehensive Rust: google/comprehensive-rust#608.

Basically, we've found that it's enough to make the device have 0664 permissions. If you agree with that, it would be nice to update the instructions here so that we can link to them from our course.

@mgeisler mgeisler requested a review from a team as a code owner May 12, 2023 12:13
@eldruin
Copy link
Member

eldruin commented May 12, 2023

I principle I agree with you that it would be better to avoid making the devices world-writable, however, I worry about users that have a different or somewhat incorrect group configuration.
I would add more guidance here at least.
What do you think @adamgreig ?

@adamgreig
Copy link
Member

I'm not sure we need to even write 664 or just delete the MODE attribute entirely (I think 664 will be the default?). Removing world write access does make sense to me. Usually we'd either pug GROUP="plugdev" or TAG+="uaccess" in its place. I'm surprised that just 664 is enough without some other changes to ensure the user's in a group that can access the device or owns that device node. I don't think there's any harm having the plugdev group and uaccess tag added on systems that don't have them, either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants