introduce a workround for float parsing #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geal
force-pushed
the
workaround-float-issues
branch
from
1b96f00
to
7cc8400
Compare
this will afford some time until we get a proper fix with minimal lexical for floats that are to large
Geal
force-pushed
the
workaround-float-issues
branch
from
7cc8400
to
66a77a2
Compare
Stargateur
reviewed
Nov 19, 2021
Comment on lines
+2109
to
+2110
| let (_i, inf) = float::<_, ()>("infinite").unwrap(); | ||
| assert!(inf.is_infinite()); |
There was a problem hiding this comment.
I think this test should fail cause it's only eat 'inf' and not 'infinite' https://github.com/Geal/nom/pull/1391/files# parse infinity before inf cause of this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will afford some time until we get a proper fix with minimal lexical for floats that are to large
not cleaned up yet
Fixes #1384 and #1421