Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming Support for Nvidia's Triton Integration #13135

Merged
merged 8 commits into from Apr 30, 2024

Conversation

Rohith-2
Copy link
Contributor

@Rohith-2 Rohith-2 commented Apr 27, 2024

Description

Implemented the streaming capabilities for Nvidia's Triton integration in llama-index

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Implemented Streaming capabilities for completion and chatting
Added examples for streaming the generation from LLM's complete functionality.
Updated example to utilise the streaming capability of Triton with complete and chat functions.
Updated example to utilise the streaming capability of Triton with complete and chat functions.
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 27, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Rohith-2 Rohith-2 changed the title Patch 3 Streaming Support for Nvidia's Triton Integration Apr 27, 2024
Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coo! This looks good to me thanks.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 28, 2024
@logan-markewich logan-markewich merged commit 93cb095 into run-llama:main Apr 30, 2024
8 checks passed
JuHyung-Son pushed a commit to UpstageAI/llama_index that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants