add matching source_node.node_id verification #13109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
| if i > 0: | ||
| if ( | ||
| i > 0 | ||
| and nodes[i - 1].source_node.node_id == node.source_node.node_id |
There was a problem hiding this comment.
I think we should also check if source_node is none or not too actually (I can imagine it being none sometimes)
There was a problem hiding this comment.
Good callout. Just pushed the change.
|
Following up :) |
logan-markewich
approved these changes
May 1, 2024
JuHyung-Son
pushed a commit
to UpstageAI/llama_index
that referenced
this pull request
May 1, 2024
* add matching source_node.node_id verification * check that source_node exists --------- Co-authored-by: Adam Lineberry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
NodeParser.get_nodes_from_documentsto verify that previous and next nodes share the same source node as the current node before definingprev_nodeandnext_noderelationships.See issue linked below for more context.
Fixes # (issue)
#13095
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
This was a very minor change and I didn't see a test that specifically covered the method I modified. Existing tests passed.
Suggested Checklist:
make format; make lintto appease the lint gods