Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DEFAULT_TEXT_TO_SQL_TMPL #12957

Closed
wants to merge 1 commit into from
Closed

Conversation

taradepan
Copy link

@taradepan taradepan commented Apr 19, 2024

There were errors caused by the generated query. If the table name is like user-data, it is suppose to be in double quotes which was not being generated properly by DEFAULT_TEXT_TO_SQL_TMPL.

Description

I have modified the DEFAULT_TEXT_TO_SQL_TMPL to generate the sql query properly. As this was causing the same error multiple times. there is no need to install any new dependencies.

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

There were errors caused by the generated query. If the table name is like user-data, it is suppose to be in double quotes which was not being generated properly by DEFAULT_TEXT_TO_SQL_TMPL.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 19, 2024
@taradepan
Copy link
Author

taradepan commented Apr 19, 2024

review-requested:[@logan-markewich]

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 19, 2024
@logan-markewich
Copy link
Collaborator

@taradepan Some thoughts before merging -- I think adding quotes changes some behaviour in certain query languages (i.e. case sensitivity, etc.)

I worry a bit about downstream effects of this, vs. you just modifying the default prompt template yourself when creating the query engine

@taradepan
Copy link
Author

taradepan commented Apr 19, 2024

@logan-markewich actually I tried it with AWS Athena. I found it that majority of the time when the table name or database name has - it's throwing errors.
image

@taradepan
Copy link
Author

@logan-markewich I think we can merge the PR now. and i don't think adding quotes will cause issues (like case sensitive)

@taradepan taradepan closed this by deleting the head repository Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants