Implement async methods in RedisKVStore #12943
Merged
+59
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
|
||
| Args: | ||
| key (str): key | ||
| val (dict): value | ||
| collection (str): collection name | ||
|
|
||
| """ | ||
| raise NotImplementedError | ||
| return self.put(key=key, val=val, collection=collection) |
There was a problem hiding this comment.
Should we take the time to actually implement the async method though?
There was a problem hiding this comment.
fake-async will still block the thread
There was a problem hiding this comment.
@philipchung light bump on this
There was a problem hiding this comment.
Unfortunately I don't have time to implement true async methods. I've used this fake async implementation with async ingestion pipeline and have not experienced any major performance degradation for my own use cases.
|
Ok, I added the actual async methods (wasn't actually too hard) |
logan-markewich
approved these changes
May 10, 2024
raghavdixit99
pushed a commit
to raghavdixit99/llama_index_lance
that referenced
this pull request
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Async methods were not implemented in RedisKVStore. This is necessary if RedisKVStore is used as an ingestion cache or docstore in an async ingestion pipeline.
Fixes #10248
Implement async methods.
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lintto appease the lint gods