Adding re-raise flag at OpenAI Agent level

[LMartinezEXEX]

Description

Added raise_error congif argument at an Agent level in the OpenAI Agent class to allow the re-raise of exception when needed (an implemented feature, although not end-to-end).

Type of Change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Added new unit/integration tests
• Added new notebook (that tests end-to-end)
• I stared at the code and made sure it makes sense

Suggested Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added Google Colab support for the newly added notebooks.
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I ran make format; make lint to appease the lint gods

[LMartinezEXEX]

I see some checks failed due to a 503 Service Unavailable, any idea why or if this is a regular situation? I am not able to re-trigger the failed checks.

[santimarro]

LGTM

[logan-markewich]

My general feedback is this arg is pretty generic, but its actual use only covers one very specific use-case, which is kind of misleading

Is there any way we can think of to improve this? A better name? Handle more scenarios where errors are caught?

[logan-markewich]

Also, please double check the unit tests

[LMartinezEXEX]

Hi Logan! Thank you for the comments! :)

So regarding this feature, absolutely! I understand there are multiple places where exceptions are raised which are captured by llama-index code.
This was motivated by Azure filtering error exception while streaming, I needed to capture in my side the exception.

I noticed the functionality (i.e. the flag to re-reaise the exception) was there, although not end-to-end implemented.
My main objective was to introduce the parameter at an Agent level, as this was recommended in a thread in Discord.

I'm no expert of the whole llama-index codebase, but I am sure that with this small step, any other in need of this kind of feature will be able to adjust, in future PRs, the code to get exception in particular scenarios if they need!

Regarding the naming of the variable at an Agent level, wdyt of capture_exception or rethrow_exception, to be more explicit of not an error, but an exception.

And to finish, I checked the unit tests, they neither pass in the main branch (at least on my setup). I would take a look.

Please let me know about your thought on this! ✨

[logan-markewich]

In order to avoid hiding actual errors, I've removed this option altogether, and errors will always be raised.

Going to close this for now.