Added support for Qdrant search parameters #12662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enable binary quantisation and additional customisations https://qdrant.tech/articles/binary-quantization
dosubot
bot
added
the
size:S
|
I feel like quantization should be more explicitly supported, but this is a good first step too |
| @@ -608,6 +608,9 @@ async def aquery( | |||
| # build metadata filters | |||
| query_filter = cast(Filter, self._build_query_filter(query)) | |||
|
|
|||
| # NOTE: users can pass in search_params | |||
| search_params = kwargs.get("search_params") | |||
There was a problem hiding this comment.
Should we do the same for the sync query?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Will commit tests soon
To simply pass search params to the Qdrant client during single search and batch search requests.
This feature is added specifically to enable quantisation support https://qdrant.tech/articles/binary-quantization
New Package?
Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lintto appease the lint gods