Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: max tokens #820

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: max tokens #820

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

@vercel Vercel
Copy link

vercel bot commented May 8, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llama-index-ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 3:15am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 8, 2024 •
edited

⚠️ No Changeset found

Latest commit: f1906bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

himself65
himself65 commented May 8, 2024
View reviewed changes
packages/core/src/ChatHistory.ts
super();
this.messages = init?.messages ?? [];
this.messagesBefore = this.messages.length;
this.summaryPrompt = init?.summaryPrompt ?? defaultSummaryPrompt;
this.llm = init?.llm ?? new OpenAI();
if (!this.llm.metadata.maxTokens) {
if (!this.llm.metadata.maxTokens || !init?.maxTokens) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use Infinity if it's undefined?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code below won't work if maxTokens is not specified, so I think it's ok, to throw this error, it's basically a configuration error.

this class also needs a tokenizer to work correctly (and for ollama it could be any LLM with any tokenizer).

So I think we should set tokenizer to globalsHelper.defaultTokenizer.encode only if the LLM is OpenAI and throw an error if tokenizer is not explicitly specified otherwise

@himself65 himself65 marked this pull request as draft May 8, 2024 07:56
@himself65 himself65 force-pushed the himself65/20240508/max-token branch from e61e843 to f1906bf Compare May 9, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusschiesser marcusschiesser Awaiting requested review from marcusschiesser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@himself65 @marcusschiesser