Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use query bundle #702

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: use query bundle #702

wants to merge 7 commits into from

Conversation

himself65
Copy link
Member

@himself65 himself65 commented Apr 10, 2024 •
edited

Upstream: #704

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2024 •
edited

⚠️ No Changeset found

Latest commit: 9f6bd8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 10, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llama-index-ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 10:08pm

himself65
himself65 commented Apr 10, 2024
View reviewed changes
packages/core/e2e/node/snapshot/llm.snap Outdated
{
"id": "de46b84e-7345-430f-b8fa-423354b630c9",
"response": {
"raw": {},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We found a bug here, raw should be something actually

@himself65 himself65 marked this pull request as draft April 10, 2024 07:32
marcusschiesser
marcusschiesser approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@marcusschiesser marcusschiesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@himself65 looking great!

@himself65 himself65 marked this pull request as ready for review April 16, 2024 21:44
@himself65 himself65 closed this Apr 16, 2024
@himself65 himself65 deleted the himself65/20240410/queryEngine branch April 16, 2024 21:46
@himself65 himself65 restored the himself65/20240410/queryEngine branch April 16, 2024 21:46
@himself65 himself65 reopened this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusschiesser marcusschiesser marcusschiesser approved these changes

@yisding yisding Awaiting requested review from yisding

@EmanuelCampos EmanuelCampos Awaiting requested review from EmanuelCampos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@himself65 @marcusschiesser