Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prompt mustache #665

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

feat: prompt mustache #665

wants to merge 13 commits into from

Conversation

EmanuelCampos
Copy link
Collaborator

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2024 •
edited

⚠️ No Changeset found

Latest commit: a517415

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 25, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llama-index-ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 11:03pm

@EmanuelCampos EmanuelCampos mentioned this pull request Mar 25, 2024
Closed
marcusschiesser
marcusschiesser reviewed Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@marcusschiesser marcusschiesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @EmanuelCampos

packages/core/src/llm/base.ts
Comment on lines +50 to +63
if (stream) {
const stream = await this.complete({
prompt,
parentEvent,
stream: true,
});

return stream;
}

return this.complete({
prompt,
parentEvent,
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess this doesn't work in TS?

Suggested change
if (stream) {
const stream = await this.complete({
prompt,
parentEvent,
stream: true,
});
return stream;
}
return this.complete({
prompt,
parentEvent,
});
retrun await this.complete({
prompt,
parentEvent,
stream,
});

packages/core/src/llm/ollama.ts
predict(
params: unknown,
): Promise<AsyncIterable<CompletionResponse>> | Promise<CompletionResponse> {
throw new Error("Method not implemented.");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new Error("Method not implemented.");
// TODO: Consider using BaseLLM for Ollama which has a default implementation for predict
throw new Error("Method not implemented.");

packages/core/tests/prompts/Prompt.test.ts

import { Prompt } from "llamaindex/prompts/types";

describe("Prompt", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the usage of Prompt looks nice and clean!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusschiesser marcusschiesser marcusschiesser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EmanuelCampos @marcusschiesser