Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metadata filtering on simplevectorstore #493

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

swiecki
Copy link

@swiecki swiecki commented Jan 31, 2024

a starting point for a potential implementation of metadata filtering on simple vector store

Copy link

changeset-bot bot commented Jan 31, 2024

⚠️ No Changeset found

Latest commit: ed30bee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llama-index-ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 7:54pm

@swiecki swiecki changed the title started to implement metadata filtering started to implement metadata filtering on simplevectorstore Jan 31, 2024
@swiecki swiecki changed the title started to implement metadata filtering on simplevectorstore feat: metadata filtering on simplevectorstore Jan 31, 2024
@swiecki
Copy link
Author

swiecki commented Jan 31, 2024

I'm hoping someone can take this as a starting point and finish the implementation from here. Fair warning what is present here might be garbage relative to the standards you guys are looking for.

@marcusschiesser
Copy link
Collaborator

@swiecki, that already looks very good! Great job, thanks a lot. Can you add a unit test and a changeset (just call pnpm changeset) - then I would be happy to merge it

@EmanuelCampos
Copy link
Collaborator

bump @swiecki

@sirpy
Copy link

sirpy commented May 12, 2024

metadataDict is used, but its:

  1. not defined
  2. never filled with content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants