New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add epub file reader support #236
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Apply Sweep Rules to your PR?
|
Thanks for doing this! Is this ready to merge? |
nope. I need more tests. |
I'm not sure is there any ci for nextjs app? Or should I test it in playground? |
looks cool! bump @m1911star any update here? |
hi there, sorry for the late reply. I just got back from vacation. Currently, I am still looking for a suitable parser to adapt. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @m1911star looking good. Please have a look at the comments and also run pnpx changeset
in root to generate a changeset file
let's have a try |
examples/data/wells.epub
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this example taken from? what license?
@@ -1,6 +1,7 @@ | |||
export * from "./AssemblyAIReader.js"; | |||
export * from "./CSVReader.js"; | |||
export * from "./DocxReader.js"; | |||
export * from "./EpubReader.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer not to export this to root. And be careful with edge runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we download from somewhere instead of leave it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep. will remove it
async function main() { | ||
// Load PDF | ||
const reader = new EpubReader(); | ||
const documents = await reader.loadData("data/wells.epub"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m1911star you can load the ebub from an URL here instead
since I have too many epub files, I tried to add epub reader
deps